Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make system time optional in provision and restore #105

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Conversation

robin-nitrokey
Copy link
Member

Typically, we want to use the current time as the system time. With this patch, the system time argument is made optional in provision and restore and set to the current time if not set.

Fixes: #96

Typically, we want to use the current time as the system time.  With
this patch, the system time argument is made optional in provision and
restore and set to the current time if not set.

Fixes: #96
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (50f84ff) 80.01% compared to head (4b649ea) 80.00%.

Files Patch % Lines
nethsm/__init__.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   80.01%   80.00%   -0.01%     
==========================================
  Files         750      750              
  Lines       13359    13363       +4     
==========================================
+ Hits        10689    10691       +2     
- Misses       2670     2672       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robin-nitrokey robin-nitrokey merged commit 31b1cd9 into main Nov 26, 2023
6 of 8 checks passed
@robin-nitrokey robin-nitrokey deleted the provision branch November 26, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provision: make system_time optional
1 participant