Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CredentialData: (de)serialize rp and user with serde_indexed #57

Open
sosthene-nitrokey opened this issue Feb 12, 2024 · 0 comments
Open

CredentialData: (de)serialize rp and user with serde_indexed #57

sosthene-nitrokey opened this issue Feb 12, 2024 · 0 comments

Comments

@sosthene-nitrokey
Copy link

These are currently (de)serialized with the normal serde derive implementation, they could instead be made more compact by using a serde_indexed approach.

There would be the challenge of needing to either migrate, or to support deserialisation of both approaches.

For many credentials, this should save around 22 bytes of data, or more than a 10% gain.
@sosthene-nitrokey sosthene-nitrokey mentioned this issue Feb 12, 2024
Open
sosthene-nitrokey added a commit to sosthene-nitrokey/cbor-smol that referenced this issue Feb 12, 2024
@sosthene-nitrokey
deserialize_identifier: add support for all types expected by serde
387cb26 
The default serde deserialize derive accepts 3 types for identifiers:

- The name of the field as `str`
- The name of the field as ascii bytes
- The index of the field as u64

This PR changes deserialize_identifier to have compatibility with all of these
This is necessary for Nitrokey/fido-authenticator#57,
which needs compatibility with both the str variant and the index variant
sosthene-nitrokey added a commit to sosthene-nitrokey/cbor-smol that referenced this issue Feb 12, 2024
@sosthene-nitrokey
deserialize_identifier: add support for all types expected by serde
327f723 
The default serde deserialize derive accepts 3 types for identifiers:

- The name of the field as `str`
- The name of the field as ascii bytes
- The index of the field as u64

This PR changes deserialize_identifier to have compatibility with all of these
This is necessary for Nitrokey/fido-authenticator#57,
which needs compatibility with both the str variant and the index variant
@sosthene-nitrokey sosthene-nitrokey mentioned this issue Feb 12, 2024
Merged
sosthene-nitrokey added a commit to sosthene-nitrokey/cbor-smol that referenced this issue Mar 27, 2024
@sosthene-nitrokey
deserialize_identifier: add support for all types expected by serde
0d51c02 
The default serde deserialize derive accepts 3 types for identifiers:

- The name of the field as `str`
- The name of the field as ascii bytes
- The index of the field as u64

This PR changes deserialize_identifier to have compatibility with all of these
This is necessary for Nitrokey/fido-authenticator#57,
which needs compatibility with both the str variant and the index variant
sosthene-nitrokey added a commit to sosthene-nitrokey/cbor-smol that referenced this issue Sep 13, 2024
@sosthene-nitrokey
deserialize_identifier: add support for all types expected by serde
8940014 
The default serde deserialize derive accepts 3 types for identifiers:

- The name of the field as `str`
- The name of the field as ascii bytes
- The index of the field as u64

This PR changes deserialize_identifier to have compatibility with all of these
This is necessary for Nitrokey/fido-authenticator#57,
which needs compatibility with both the str variant and the index variant
sosthene-nitrokey added a commit to sosthene-nitrokey/cbor-smol that referenced this issue Sep 13, 2024
@sosthene-nitrokey
deserialize_identifier: add support for all types expected by serde
535cfde 
The default serde deserialize derive accepts 3 types for identifiers:

- The name of the field as `str`
- The name of the field as ascii bytes
- The index of the field as u64

This PR changes deserialize_identifier to have compatibility with all of these
This is necessary for Nitrokey/fido-authenticator#57,
which needs compatibility with both the str variant and the index variant
sosthene-nitrokey added a commit to sosthene-nitrokey/cbor-smol that referenced this issue Sep 13, 2024
@sosthene-nitrokey
deserialize_identifier: add support for all types expected by serde
c4d6597 
The default serde deserialize derive accepts 3 types for identifiers:

- The name of the field as `str`
- The name of the field as ascii bytes
- The index of the field as u64

This PR changes deserialize_identifier to have compatibility with all of these
This is necessary for Nitrokey/fido-authenticator#57,
which needs compatibility with both the str variant and the index variant
sosthene-nitrokey added a commit to sosthene-nitrokey/cbor-smol that referenced this issue Oct 2, 2024
@sosthene-nitrokey
deserialize_identifier: add support for all types expected by serde
ef19d7e 
The default serde deserialize derive accepts 3 types for identifiers:

- The name of the field as `str`
- The name of the field as ascii bytes
- The index of the field as u64

This PR changes deserialize_identifier to have compatibility with all of these
This is necessary for Nitrokey/fido-authenticator#57,
which needs compatibility with both the str variant and the index variant
sosthene-nitrokey added a commit to trussed-dev/cbor-smol that referenced this issue Oct 2, 2024
@sosthene-nitrokey
deserialize_identifier: add support for all types expected by serde
a0d0296 
The default serde deserialize derive accepts 3 types for identifiers:

- The name of the field as `str`
- The name of the field as ascii bytes
- The index of the field as u64

This PR changes deserialize_identifier to have compatibility with all of these
This is necessary for Nitrokey/fido-authenticator#57,
which needs compatibility with both the str variant and the index variant
sosthene-nitrokey added a commit to trussed-dev/cbor-smol that referenced this issue Oct 7, 2024
@sosthene-nitrokey
deserialize_identifier: add support for all types expected by serde
32df258 
The default serde deserialize derive accepts 3 types for identifiers:

- The name of the field as `str`
- The name of the field as ascii bytes
- The index of the field as u64

This PR changes deserialize_identifier to have compatibility with all of these
This is necessary for Nitrokey/fido-authenticator#57,
which needs compatibility with both the str variant and the index variant
sosthene-nitrokey added a commit to trussed-dev/cbor-smol that referenced this issue Oct 7, 2024
@sosthene-nitrokey
deserialize_identifier: add support for all types expected by serde
c48b2b2 
The default serde deserialize derive accepts 3 types for identifiers:

- The name of the field as `str`
- The name of the field as ascii bytes
- The index of the field as u64

This PR changes deserialize_identifier to have compatibility with all of these
This is necessary for Nitrokey/fido-authenticator#57,
which needs compatibility with both the str variant and the index variant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sosthene-nitrokey