Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Decouple Snowflake merge writer from Snowflake Sync task to separate writer #88

Open
mikita-sakalouski opened this issue Nov 5, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mikita-sakalouski
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently the SynchronizeDeltaToSnowflakeTask implements merge logic for Snowflake target. Because the merge configuration is injected inside the task itself it becomes difficult to customize it. Also the task itself is overloaded with logic and function.

Describe the solution you'd like

I would like to decouple merge logic from Task itself and have a separated SnowflakeMergeWriter which can be passed to the task if needed.

Describe alternatives you've considered

Keep as it is and make users to override all custom logic.

@mikita-sakalouski mikita-sakalouski added the enhancement New feature or request label Nov 5, 2024
@mikita-sakalouski mikita-sakalouski self-assigned this Nov 5, 2024
@mikita-sakalouski mikita-sakalouski added this to the 0.9.0 milestone Nov 5, 2024
@dannymeijer dannymeijer modified the milestones: 0.9.0, 0.10.0 Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants