Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GTM #7

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Add GTM #7

merged 1 commit into from
Mar 8, 2024

Conversation

cgilbe27
Copy link

@cgilbe27 cgilbe27 commented Mar 7, 2024

Summary by CodeRabbit

  • New Features
    • Integrated Google Tag Manager for enhanced tracking capabilities.

@cgilbe27 cgilbe27 self-assigned this Mar 7, 2024
Copy link

coderabbitai bot commented Mar 7, 2024

Walkthrough

This update introduces Google Tag Manager to the website by adding relevant script and noscript elements to the HTML document. This addition is aimed at enhancing tracking capabilities, allowing for a more detailed analysis of user interactions and website performance.

Changes

File(s) Change Summary
index.html Added Google Tag Manager script and noscript elements.

🐇✨
In the realm of code, where elements entwine,
A rabbit hopped in, with a plan so divine.
With a flick and a hop, and a script tag in sight,
It whispered to data, "Now, track this site right."
Through noscript and script, the magic was spun,
A tale of tracking, under the digital sun.
🌟🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

github-actions bot commented Mar 7, 2024

Visit the preview URL for this PR (updated for commit 7575651):

https://nibiru-explorer--pr7-chore-gtm-ewdpp5pw.web.app

(expires Thu, 21 Mar 2024 20:39:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 0653a911498be5ff7b1517207d84ddca0bcce10b

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c735c55 and 7575651.
Files selected for processing (1)
  • index.html (2 hunks)
Additional comments: 1
index.html (1)
  • 27-37: The noscript tag for GTM has been correctly added for environments where JavaScript is disabled. This ensures that tracking capabilities are still partially available in such cases. However, there are a couple of points to consider:
  • Accessibility: Ensure that the use of an iframe within a noscript tag does not negatively impact the accessibility of your website. While the iframe is hidden and has a size of 0, it's good practice to verify that it doesn't interfere with screen readers or other assistive technologies.
  • Privacy Compliance: Similar to the script tag, ensure that the use of GTM complies with privacy laws and that necessary consent is obtained for users, especially when tracking is possible without JavaScript enabled.

index.html Show resolved Hide resolved
@cgilbe27 cgilbe27 merged commit 115e49e into master Mar 8, 2024
2 checks passed
@cgilbe27 cgilbe27 deleted the chore/gtm branch March 8, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants