Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDs are reused for form inputs #45

Open
keyansheng opened this issue Jul 30, 2024 · 1 comment
Open

IDs are reused for form inputs #45

keyansheng opened this issue Jul 30, 2024 · 1 comment

Comments

@keyansheng
Copy link
Collaborator

keyansheng commented Jul 30, 2024

The current design uses names as IDs for form input, but since form inputs are reused, IDs are not unique anymore and labels are unable to reference the correct ID.

Suggestion:

  • Wrap inputs inside labels to avoid the use of IDs, which are prone to conflicts due to the reusable nature of components
  • Move labels inside input components
@NhatMinh0208
Copy link
Owner

Noted, will investigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants