Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mocks clean up #1161

Open
roxdanila opened this issue Jul 3, 2024 · 0 comments
Open

Mocks clean up #1161

roxdanila opened this issue Jul 3, 2024 · 0 comments
Assignees

Comments

@roxdanila
Copy link
Contributor

roxdanila commented Jul 3, 2024

  1. Lots of Cover mocks still contain products, productTypes and similar leftovers which should have been removed.
  2. StakingProducts and StakingPool have a Cover mock containing the allocateCapacity function. The function is called from the tests so it will call the StakingPool which is quite redundant as it could have been called from the tests directly impersonating the cover contract address.
  3. The CPMockCover should implement the legacy cover contract for the migration tests, setProductsAndProductTypes should not be present on an actual cover contract mock. Technically this test is short lived, so maybe we can remove the test and its leftover functions entirely after the upgrade.
  4. There could be more issues, these are just some of them.
@roxdanila roxdanila converted this from a draft issue Jul 3, 2024
@roxdanila roxdanila moved this from TODO to ⚖ Backlog in Engineering Tracker 💻 Jul 3, 2024
@roxdanila roxdanila moved this from ⚖ Backlog to TODO in Engineering Tracker 💻 Jul 12, 2024
@MilGard91 MilGard91 moved this from TODO to 🏗 In progress in Engineering Tracker 💻 Jul 22, 2024
@MilGard91 MilGard91 moved this from 🏗 In progress to TODO in Engineering Tracker 💻 Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: TODO
Development

No branches or pull requests

2 participants