You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Lots of Cover mocks still contain products, productTypes and similar leftovers which should have been removed.
StakingProducts and StakingPool have a Cover mock containing the allocateCapacity function. The function is called from the tests so it will call the StakingPool which is quite redundant as it could have been called from the tests directly impersonating the cover contract address.
The CPMockCover should implement the legacy cover contract for the migration tests, setProductsAndProductTypes should not be present on an actual cover contract mock. Technically this test is short lived, so maybe we can remove the test and its leftover functions entirely after the upgrade.
There could be more issues, these are just some of them.
The text was updated successfully, but these errors were encountered:
products
,productTypes
and similar leftovers which should have been removed.StakingProducts
andStakingPool
have aCover
mock containing theallocateCapacity
function. The function is called from the tests so it will call theStakingPool
which is quite redundant as it could have been called from the tests directly impersonating the cover contract address.CPMockCover
should implement the legacy cover contract for the migration tests,setProductsAndProductTypes
should not be present on an actual cover contract mock. Technically this test is short lived, so maybe we can remove the test and its leftover functions entirely after the upgrade.The text was updated successfully, but these errors were encountered: