Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map out repeated constants in various contracts #1084

Open
rackstar opened this issue Mar 18, 2024 · 1 comment
Open

Map out repeated constants in various contracts #1084

rackstar opened this issue Mar 18, 2024 · 1 comment
Labels
enhancement New feature or request system

Comments

@rackstar
Copy link
Contributor

Overview

Constants used throughout the protocol are often redeclared. A mismatch between contracts could introduce flaws, such as incorrect slippage protection.

Protocol-wide constants should be declared in a single source file and imported as needed to ensure consistency and prevent the likelihood of a value mismatch.

Examples of redeclared constants are:

  • ETH
  • MAX_SLIPPAGE_DENOMINATOR
@rackstar rackstar added the enhancement New feature or request label Mar 18, 2024
@roxdanila
Copy link
Contributor

similar to #453

@roxdanila roxdanila added low question Further information is requested labels May 29, 2024
@roxdanila roxdanila changed the title feat: constants.sol source file Map out repeated constants in various contracts and put them in a constants.sol source file May 29, 2024
@roxdanila roxdanila removed the question Further information is requested label May 29, 2024
@roxdanila roxdanila changed the title Map out repeated constants in various contracts and put them in a constants.sol source file Map out repeated constants in various contracts May 29, 2024
@roxdanila roxdanila added question Further information is requested system enhancement New feature or request and removed enhancement New feature or request low system question Further information is requested labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request system
Projects
Engineering Tracker 💻
Status: ⚖ Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rackstar @roxdanila