Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose debugging flag to CLI #17

Merged
merged 3 commits into from
Jan 27, 2024
Merged

expose debugging flag to CLI #17

merged 3 commits into from
Jan 27, 2024

Conversation

CodyCBakerPhD
Copy link
Collaborator

relevant but does not close #4

@oruebel Per your question on debugging #5 in the run command, this adds a CLI flag --debug that show display tracebacks

NOTE 1: that relies on the tracebacks actually triggering due to an error in the test case itself - I don't think it capture errors in the setup

NOTE 2: for the internet dependent tests, and this is especially prevalent for fsspec on my device, the tests can show up as 'failed' without any traceback if they hit the maximum timeout value. This can be configured per test I believe, as an attribute on the class similar to the repeat value (which if the test is expected to take a long time, you might want to limit anyway)

@CodyCBakerPhD
Copy link
Collaborator Author

I also exposed the --bench flag so you can run your new subtests without running the rest of the suite

@CodyCBakerPhD CodyCBakerPhD self-assigned this Jan 27, 2024
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review January 27, 2024 17:30
@oruebel
Copy link
Contributor

oruebel commented Jan 27, 2024

Thanks @CodyCBakerPhD

@oruebel oruebel merged commit 6c76785 into main Jan 27, 2024
1 check passed
@oruebel oruebel deleted the debugging_cli branch January 27, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore and document --bench argument pattern
2 participants