-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerating an out-of-date environment json fails #36
Comments
Would you mind copying/pasting the contents of your Did this file exist from an earlier point in this projects history (such as from calling simply If not, did you call |
I honestly don't remember, but I do believe the previous file was generated before you had added the custom modifications.
Yes, but
I unfortunately don't have the original asv file any more. One way to reproduce the issue is to just remove one of the expected keys from the The changes I made in the corresponding PR #37, in many ways just safeguard against missing keys and forces that the file is being regenerated also if expected keys are missing. So it just catches those as additional cases that should trigger a recreation of the The benchmarks are working now on my labtop. |
I see, I always delete the file manually before running that under the assumption it's a clean system I think it would be a lot simpler, instead of catching any/all weird conditions it might just be worth it to regenerate the I'll open a PR for that, will cut down on the amount of code |
Sounds good. In that case we can probably just close the PR I had created |
fixed by #38 |
The text was updated successfully, but these errors were encountered: