Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Units.waveform_mean and Units.waveform_sd ragged #576

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Make Units.waveform_mean and Units.waveform_sd ragged #576

merged 2 commits into from
Apr 25, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Apr 25, 2024 •
edited
Loading

See NeurodataWithoutBorders/pynwb#1693

Summary of changes

  • Add new columns to the Units table to make Units.waveform_mean and Units.waveform_sd ragged.

Checklist

For all schema changes:

  • Add release notes for the PR to docs/format/source/format_release_notes.rst.
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.
  • Make sure that hdmf-common-schema points to the latest release and not the latest commit on the main branch.

@rly rly marked this pull request as ready for review April 25, 2024 08:14
@rly
Copy link
Contributor Author

rly commented Apr 25, 2024

@mavaylon1 @stephprince Please review and in particular, let me know if the docs make sense. Open to suggestions for better wording...

@rly rly self-assigned this Apr 25, 2024
@rly rly added the category: proposal proposed enhancements or new features label Apr 25, 2024
@rly rly added this to the Next Release milestone Apr 25, 2024
stephprince
stephprince approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I thought the phrasing was good.

@mavaylon1 mavaylon1 merged commit 3ad7aa3 into dev Apr 25, 2024
5 checks passed
@mavaylon1 mavaylon1 deleted the waveform_mean_index branch April 25, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavaylon1 mavaylon1 mavaylon1 approved these changes

@stephprince stephprince stephprince approved these changes

Assignees

@rly rly

Labels
category: proposal proposed enhancements or new features
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rly @mavaylon1 @stephprince