-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] add enhanced subject #80
base: master
Are you sure you want to change the base?
Conversation
@ln-vidrio I'm playing with including more information in the Subject object, and I am running into an issue that I think may be a bug in matnwb. On this branch, when I run Error using types.util.checkDtype (line 107)
Property `surgeries` must be a types.core.Surgeries.
Error in types.core.Subject/validate_surgeries (line 134)
val = types.util.checkDtype('surgeries', 'types.core.Surgeries',
val);
Error in types.core.Subject/set.surgeries (line 99)
obj.surgeries = obj.validate_surgeries(val);
Error in types.core.Subject (line 64)
obj.surgeries = p.Results.surgeries;
|
119c4e1 |
@ln-vidrio thanks! That works but now I think I found another quantity bug. The following code: subject = types.core.Subject('surgeries',types.core.Surgeries());
file = nwbfile('session_description', 'a test NWB File', ...
'identifier', 'blockname', ...
'session_start_time', datestr(now, 'yyyy-mm-dd HH:MM:SS'), ...
'file_create_date', datestr(now, 'yyyy-mm-dd HH:MM:SS'),...
'general_subject',subject);
nwbExport(file, 'test.nwb') runs but should throw an error.
|
8a91480 should be correct. I opted against checking on construction since these are also called when reading nwbfiles. |
Yeah that's reasonable |
is it really still WiP @bendichter or might want to be closed (or converted to draft at least)? |
No description provided.