Changes for NML v2.3 release #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
This is required for conversion to NEURON. The members themselves do not need to be included.
The schema does not require the `name` attribute in `Segment`. However, the NEURON code generator seems to require it: ``` Exception: java.lang.NullPointerException: Cannot invoke "String.equals(Object)" because the return value of "org.neuroml.model.Segment.getName()" is null ```
… `Exception` Specific errors are better than generic ones.
This is required to ensure that segment groups have already been defined before they are included in the default ones.
No need for it to be limited to the utility function.
otherwise sphinx fails with:
```
File
"/home/asinha/Documents/02_Code/00_mine/NeuroML/software/libNeuroML/neuroml/loaders.py",
line 191, in <module>
) -> neuroml.nml.nml.NeuroMLDocument:
AttributeError: module 'neuroml' has no attribute 'nml'
```
Not sure what the root cause is, but this tweak fixes it.
Feat/cell optimise natsort -> exp
Given that we have a well defined structure, we should ideally be able to generate all paths automatically. The information is present, we just need to figure out how to use it.
Towards semi-automated path generation
Use natsort to properly sort segments/groups when optimising
To v0.5.5; updated schema (with hindmarsh rose) and regenerated nml.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.