Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxFee field for all types of transactions should be removed for V3 #2129

Open
TAdev0 opened this issue Sep 10, 2024 · 0 comments · May be fixed by #2130
Open

MaxFee field for all types of transactions should be removed for V3 #2129

TAdev0 opened this issue Sep 10, 2024 · 0 comments · May be fixed by #2130

Comments

@TAdev0
Copy link

TAdev0 commented Sep 10, 2024

Here is the official spec / doc from Starknet :

https://docs.starknet.io/architecture-and-concepts/network-architecture/transactions

MaxFee was used in V0 / V1 (and V2 for declare) , setting the maximum fee that the sender is willing to pay for the transaction.

This MaxFee field has been replaced by a combination of resource_bounds and tip to handle fees for the V3 of all tx types (declare, deploy, invoke).

Currently, Juno codebase suggests that MaxFee is present also in V3 transactions which is wrong, as it is added in the list of first fields that are ''common'', and then you list fields for specific with a comment, as shown here:

Deploy
https://github.com/NethermindEth/juno/blob/main/core/transaction.go#L228

Invoke
https://github.com/NethermindEth/juno/blob/main/core/transaction.go#L259

Declare
https://github.com/NethermindEth/juno/blob/main/core/transaction.go#L310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant