Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File operations #41

Merged
merged 5 commits into from
Oct 2, 2023
Merged

File operations #41

merged 5 commits into from
Oct 2, 2023

Conversation

bmrussell
Copy link
Contributor

@bmrussell bmrussell commented Jul 7, 2023 •
edited
Loading

Hi - I noticed there were no examples of file handling in the Python client library. I noticed the examples shown in the documentation didn't quite work. This code runs successfully on the NetApp Labs environment.

It:

  • Enumerates volumes to find the requested volume (instead of using .get(), just to demonstrate)
  • Creates a folder structure with files
  • Lists that structure recursively
  • Cleans up

Hope this helps others.

Brian Russell added 2 commits July 7, 2023 16:14
Example file operations
d2beef6
checked for pep8
6eb3af2 
Signed-off-by: Brian Russell <bmrussell>
noorbuchi
noorbuchi suggested changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@noorbuchi noorbuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this great example! I have few suggestions. Once addressed, it should be good to merge.

examples/python_client_library/file_operations.py Outdated Show resolved Hide resolved
examples/python_client_library/file_operations.py Outdated Show resolved Hide resolved
noorbuchi
noorbuchi suggested changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@noorbuchi noorbuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the fixes and apologies for the late response. I ran the linting checks and they're currently failing. Can you please add fixes so that the build is passing. We should be good to merge after. Thanks!

Brian Russell added 2 commits October 2, 2023 11:30
Correcting linting issues
a135ca3
Added signoff
29c143d 
Signed-off-by: Brian Russell <bmrussell>
@bmrussell
Copy link
Contributor Author

Thanks for the heads up @noorbuchi, the module lints cleanly locally now. Might be worth a reminder to lint in CONTRIBUTING.md?

@noorbuchi noorbuchi merged commit 7e3ecc8 into NetApp:master Oct 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noorbuchi noorbuchi noorbuchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmrussell @noorbuchi