NeoUI - Custom loading screen, wrapped text #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Re-route the old VGUI text/progress into NeoUI * Loading vs disconnect states by title locale index * Single-progress bar as 2nd one not used * Preload map name if known (serverlist + new game) * fixes NeotokyoRebuild#603
nullsystem
force-pushed
the
GH-603_OverrideLoading
branch
from
b31034e
to
c811740
Compare
nullsystem
force-pushed
the
GH-603_OverrideLoading
branch
from
c811740
to
434446d
Compare
AdamTadeusz
previously approved these changes
Oct 9, 2024
| { | ||
| if (IGameUI *pGameUI = reinterpret_cast<IGameUI *>(gameUIFactory(GAMEUI_INTERFACE_VERSION, nullptr))) | ||
| { | ||
| g_pNeoLoading = new CNeoLoading; |
There was a problem hiding this comment.
Should g_pNeoLoading be deleted and the value of the pointer reset in ~ClientModeShared()
AdamTadeusz
requested changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NeoUI::LabelWrapfor a wrapped version of a labelNeoUI::Progressa read-only progress barToolchain
Linked Issues