Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading calibration extremely slow when using many segments #476

Open
silbe opened this issue Mar 8, 2022 · 5 comments
Open

Loading calibration extremely slow when using many segments #476

silbe opened this issue Mar 8, 2022 · 5 comments
Labels
stale Long time no reaction, will be closed soon

Comments

@silbe
Copy link
Contributor

silbe commented Mar 8, 2022

Describe the bug
When using many segments (e.g. ~50) loading the calibration (and probably saving it — don't remember right now) takes over an hour with 100% CPU load even on a reasonably beefy PC. Performing the calibration also takes a long time of 100% CPU load between measurements.

This is probably caused by having each calibration point represented as a separate instance in Python rather than using a single instance and storing the coefficients in a NumPy array.

In the long run it would probably be a good idea to use the calibration classes from scikit-rf instead. That would also make it easier to support additional calibration methods like TRL.

To Reproduce
Steps to reproduce the behavior:

  1. Set number of points to 1023.
  2. Set number of segments to 50.
  3. Perform calibration using assistant.
  4. Save calibration.
  5. Load calibration again.

Expected behavior
Loading a calibration file with a couple thousand points should only take a few seconds.

Screenshots
n/a

Desktop (please complete the following information):

  • OS: Linux
  • Python version: 3.9.2
  • NanoVNA-Saver version: v0.4.0-pre

Additional context
See description.

@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale Long time no reaction, will be closed soon label Oct 10, 2022
@silbe
Copy link
Contributor Author

silbe commented Dec 13, 2022

I've tried this again with current main (commit fb50f4a) and loading large calibration files still takes at least several minutes (didn't wait longer). Please reopen this ticket.

@zarath zarath reopened this Dec 13, 2022
@github-actions github-actions bot removed the stale Long time no reaction, will be closed soon label Dec 14, 2022
@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale Long time no reaction, will be closed soon label Mar 14, 2023
@silbe
Copy link
Contributor Author

silbe commented Mar 14, 2023

I don't see any changes in main that I expect to significantly improve calibration loading performance so this should still be applicable.

@github-actions github-actions bot removed the stale Long time no reaction, will be closed soon label Mar 15, 2023
@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale Long time no reaction, will be closed soon label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Long time no reaction, will be closed soon
Projects
None yet
Development

No branches or pull requests

2 participants