-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading calibration extremely slow when using many segments #476
Comments
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. |
I've tried this again with current |
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. |
I don't see any changes in |
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. |
Describe the bug
When using many segments (e.g. ~50) loading the calibration (and probably saving it — don't remember right now) takes over an hour with 100% CPU load even on a reasonably beefy PC. Performing the calibration also takes a long time of 100% CPU load between measurements.
This is probably caused by having each calibration point represented as a separate instance in Python rather than using a single instance and storing the coefficients in a NumPy array.
In the long run it would probably be a good idea to use the calibration classes from scikit-rf instead. That would also make it easier to support additional calibration methods like TRL.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Loading a calibration file with a couple thousand points should only take a few seconds.
Screenshots
n/a
Desktop (please complete the following information):
Additional context
See description.
The text was updated successfully, but these errors were encountered: