python/requirements.txt is missing scikit-image, vispy, ipython, and it shouldn't contain pytest

[yurivict]

There are import statements for these in the python code, therefore they should be in requirements.txt

On the other hand, pytest should be in the tests_require clause in setup.py, see here.

Version: 1.29.0

[stevengj]

Those aren't requirements for using the meep library itself — they are optional dependencies.

For example IPython is imported in a try block to enable optional features in Jupyter, but the code still works without it:

meep/python/simulation.py

Lines 42 to 44 in b47d9ba

	try:
	from IPython.display import display
	from ipywidgets import FloatProgress

vispy is used in plot3D, so the rest of meep runs fine without it, and only that function will throw an exception if you don't have vispy installed:

meep/python/visualization.py

Lines 1064 to 1065 in b47d9ba

	from vispy.scene.visuals import Box, Mesh
	from vispy.scene import SceneCanvas, transforms

scikit-image doesn't seem to be referenced anywhere in Meep, so I'm not sure what you are referring to?

We don't use setup.py — Meep is built with a Makefile.