Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjoint TO filters not properly accounting for boundary conditions #2344

Open
smartalecH opened this issue Dec 15, 2022 · 0 comments
Open

Adjoint TO filters not properly accounting for boundary conditions #2344

smartalecH opened this issue Dec 15, 2022 · 0 comments

Comments

@smartalecH
Copy link
Collaborator

As discussed, the current adjoint TO filters are not properly accounting for boundary conditions. In theory, we should only need a single pixel around the boundary. The current codebase does an edge-based pad on all dimensions:

x = _edge_pad(x, ((kx, kx), (ky, ky)))

Maybe we need an even larger pad? (It's already padded twice what it needs to be to avoid overwriting values due to the circular convolution...)

(cc @oskooi )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant