You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As discussed, the current adjoint TO filters are not properly accounting for boundary conditions. In theory, we should only need a single pixel around the boundary. The current codebase does an edge-based pad on all dimensions:
As discussed, the current adjoint TO filters are not properly accounting for boundary conditions. In theory, we should only need a single pixel around the boundary. The current codebase does an edge-based pad on all dimensions:
meep/python/adjoint/filters.py
Line 83 in ee5324c
Maybe we need an even larger pad? (It's already padded twice what it needs to be to avoid overwriting values due to the circular convolution...)
(cc @oskooi )
The text was updated successfully, but these errors were encountered: