Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lookups for building classes and land use codes #998

Open
hannahkates opened this issue Aug 26, 2020 · 11 comments
Open

Update lookups for building classes and land use codes #998

hannahkates opened this issue Aug 26, 2020 · 11 comments

Comments

@hannahkates
Copy link
Contributor

The building classes and land use codes need to be updated with the latest codes and labels. Maybe EDM can provide these as tables that can be used as lookups.

@allthesignals
Copy link
Collaborator

@SPTKL can you point me to lookup metadata for the PLUTO building classes & land use codes?

@allthesignals
Copy link
Collaborator

@SPTKL
Copy link

SPTKL commented Oct 22, 2021

what is this for? show n tell plz

@allthesignals
Copy link
Collaborator

what is this for? show n tell plz

Oh I'm just knocking out a few issues for funsies

@allthesignals
Copy link
Collaborator

@SPTKL hmm, I updated what we have in ZoLa with EDM's metadata (see the diff: https://github.com/NYCPlanning/labs-zola/pull/1027/files), but it looks like it takes away information:

image

Do you know what these subcategories are? Maybe they're old and possibly inaccurate? For example, B1 used to be "Two Family Dwellings - Brick" but your metadata doc has "One and Two Family Buildings".

Thanks!

@allthesignals
Copy link
Collaborator

Maybe I should be using this instead? https://github.com/NYCPlanning/db-pluto/blob/main/pluto_build/data/lookup_bldgclass.csv

@hannahkates
Copy link
Contributor Author

Hey guys! Lol glad to see this is being worked on

@allthesignals
Copy link
Collaborator

Hey guys! Lol glad to see this is being worked on

@hannahkates Lol thanks. So, I think your version of this work fixed some typos. I'm not sure whether these are actual "updates" to the building classes. I'm going through the diff and proposing typo fixes back to the source (https://github.com/NYCPlanning/db-pluto/blob/main/pluto_build/data/lookup_bldgclass.csv).

Hope all is well!

@allthesignals
Copy link
Collaborator

Also, some of the new descriptions actually remove information:

image

I think it's probably best to be hands-off about the content itself and to propose description changes upstream (to https://github.com/NYCPlanning/db-pluto/blob/main/pluto_build/data/lookup_bldgclass.csv).

@allthesignals
Copy link
Collaborator

Also also, I don't think there are any updates needed for land use codes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants