-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lookups for building classes and land use codes #998
Comments
@SPTKL can you point me to lookup metadata for the PLUTO building classes & land use codes? |
what is this for? show n tell plz |
Oh I'm just knocking out a few issues for funsies |
@SPTKL hmm, I updated what we have in ZoLa with EDM's metadata (see the diff: https://github.com/NYCPlanning/labs-zola/pull/1027/files), but it looks like it takes away information: Do you know what these subcategories are? Maybe they're old and possibly inaccurate? For example, B1 used to be "Two Family Dwellings - Brick" but your metadata doc has "One and Two Family Buildings". Thanks! |
Maybe I should be using this instead? https://github.com/NYCPlanning/db-pluto/blob/main/pluto_build/data/lookup_bldgclass.csv |
Hey guys! Lol glad to see this is being worked on |
@hannahkates Lol thanks. So, I think your version of this work fixed some typos. I'm not sure whether these are actual "updates" to the building classes. I'm going through the diff and proposing typo fixes back to the source (https://github.com/NYCPlanning/db-pluto/blob/main/pluto_build/data/lookup_bldgclass.csv). Hope all is well! |
Also, some of the new descriptions actually remove information: I think it's probably best to be hands-off about the content itself and to propose description changes upstream (to https://github.com/NYCPlanning/db-pluto/blob/main/pluto_build/data/lookup_bldgclass.csv). |
Also also, I don't think there are any updates needed for land use codes. |
The building classes and land use codes need to be updated with the latest codes and labels. Maybe EDM can provide these as tables that can be used as lookups.
The text was updated successfully, but these errors were encountered: