Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix FacDB use of latest dca_operatingbusinesses #1235

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

damonmcc
Copy link
Member

@damonmcc damonmcc commented Nov 6, 2024

resolves FacDB failing in Nighty QA (#1215, logs)

successful build here

@damonmcc damonmcc force-pushed the dm-facdb-fix branch 3 times, most recently from c7154d8 to 17ee68d Compare November 7, 2024 00:05
@damonmcc damonmcc changed the title fix column name from dca_operatingbusinesses fix FacDB use of latest dca_operatingbusinesses Nov 7, 2024
@@ -52,12 +52,10 @@ def dca_operatingbusinesses(df: pd.DataFrame):
]
today = datetime.datetime.today()
covid_freeze = datetime.datetime.strptime("03/12/2020", "%m/%d/%Y")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know we had references to covid in our repo!

Copy link
Contributor

@fvankrieken fvankrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a schema change

@damonmcc damonmcc merged commit c1aa3cd into main Nov 7, 2024
15 checks passed
@damonmcc damonmcc deleted the dm-facdb-fix branch November 7, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants