Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera: IntrinsicsPinhole convenience upgrades #714

Open
orperel opened this issue May 1, 2023 · 0 comments
Open

Camera: IntrinsicsPinhole convenience upgrades #714

orperel opened this issue May 1, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@orperel
Copy link
Collaborator

orperel commented May 1, 2023

Additions to IntrinsicsPinhole:

  1. Add properties for cx and cy, which represent the actual principal points (currently we expose only x0, y0, which are deltas from the center.
  2. Add a matrix for casting from NDC to pixel space. This should be the matrix form of glViewport , to be used with the ViewProjection matrix when going from world coordinates to actual pixel coordinates (rather than world to NDC).
  3. Upgrade setter functions for the width and height properties: these should maintain the focal length invariant, but update the fov accordingly

Additions to Camera:

  1. Expose setter functions for the width and height properties.
  2. Add pin_memory() function.
@orperel orperel self-assigned this May 1, 2023
@orperel orperel added the enhancement New feature or request label May 1, 2023
@orperel orperel changed the title Camera & IntrinsicsPinhole convenience upgrades Camera: IntrinsicsPinhole convenience upgrades May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant