Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imex support #375

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Add imex support #375

merged 2 commits into from
Feb 27, 2024

Conversation

klueska
Copy link
Contributor

@klueska klueska commented Feb 26, 2024

docker run -it \
        -e NVIDIA_IMEX_CHANNELS=0,1,2047 \
        -e NVIDIA_VISIBLE_DEVICES=0 \
        ubuntu:22.04 bash -c "ls -la /dev/nvidia*"
crw-rw-rw- 1 root root 504,   0 Jan 18 12:59 /dev/nvidia-uvm
crw-rw-rw- 1 root root 504,   1 Jan 18 12:59 /dev/nvidia-uvm-tools
crw-rw-rw- 1 root root 195,   0 Jan 18 12:59 /dev/nvidia0
crw-rw-rw- 1 root root 195, 255 Jan 18 12:59 /dev/nvidiactl
 
/dev/nvidia-caps-imex-channels:
total 0
drwxr-xr-x 2 root root       100 Jan 18 21:32 .
drwxr-xr-x 6 root root       460 Jan 18 21:32 ..
crw-rw-rw- 1 root root 508,    0 Jan 18 19:11 channel0
crw-rw-rw- 1 root root 508,    1 Jan 18 19:11 channel1
crw-rw-rw- 1 root root 508, 2047 Jan 18 19:13 channel2047

@klueska klueska requested a review from elezar February 26, 2024 19:01
@klueska klueska self-assigned this Feb 26, 2024
@klueska klueska marked this pull request as draft February 26, 2024 19:01
@klueska klueska changed the title DRAFT: Add imex support Add imex support Feb 27, 2024
@klueska klueska marked this pull request as ready for review February 27, 2024 09:18
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. I'm willing to hear arguments on consistency vs simplicity.

@klueska
Copy link
Contributor Author

klueska commented Feb 27, 2024

One comment. I'm willing to hear arguments on consistency vs simplicity.

Yes. I did it for consistency.

Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Remember that we need to backport these and the libnvidia-container changes.

Created:

@elezar elezar merged commit ac63063 into NVIDIA:main Feb 27, 2024
8 checks passed
@elezar elezar mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants