Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-cleanup-on-exit option to GFD #899

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elezar
Copy link
Member

@elezar elezar commented Aug 12, 2024

This change adds a --no-cleanup-on-exit option to GFD that skips the removal of the generated labels file.

See #796

This change adds a --no-cleanup-on-exit option to GFD that skips the
removal of the generated labels file.

Signed-off-by: Evan Lezar <[email protected]>
@elezar elezar force-pushed the add-no-cleanup-on-exit-GFD-option branch from e64fb90 to 08363f4 Compare September 17, 2024 13:26
@belo4ya
Copy link
Contributor

belo4ya commented Sep 28, 2024

@elezar, are there any updates or issues related to this fix? We are still eagerly awaiting its inclusion in the next release.


One thing: as was rightly noted in comment #796 (comment), when using the NodeFeature API, such automatic cleanup does not occur. Considering this, such a general option name as --no-cleanup-on-exit may not be entirely clear and could cause some confusion. Perhaps it would be better to choose a more suitable name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants