-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CUDAX] Add a way to combine thread hierarchies #2746
Open
pciolkosz
wants to merge
3
commits into
NVIDIA:main
Choose a base branch
from
pciolkosz:hierarchy_merge
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+120
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟩 CI finished in 1h 14m: Pass: 100%/54 | Total: 4h 38m | Avg: 5m 09s | Max: 16m 28s | Hits: 61%/238
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
🏃 Runner counts (total jobs: 54)
# | Runner |
---|---|
43 | linux-amd64-cpu16 |
5 | linux-amd64-gpu-v100-latest-1 |
4 | linux-arm64-cpu16 |
2 | windows-amd64-cpu16 |
miscco
reviewed
Nov 8, 2024
cudax/include/cuda/experimental/__hierarchy/hierarchy_dimensions.cuh
Outdated
Show resolved
Hide resolved
🟩 CI finished in 1h 27m: Pass: 100%/54 | Total: 4h 44m | Avg: 5m 15s | Max: 20m 26s | Hits: 61%/246
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
🏃 Runner counts (total jobs: 54)
# | Runner |
---|---|
43 | linux-amd64-cpu16 |
5 | linux-amd64-gpu-v100-latest-1 |
4 | linux-arm64-cpu16 |
2 | windows-amd64-cpu16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to implement combination of kernel configurations, we first need a way to combine thread hierarchies.
In case of overlap between the hierarchies one of them should have the priority over the other. I decided to implement it as a member function
combine
on the hierarchy type to make it less symmetrical than a free function. In case of overlap the object on whichcombine
was called has priority over the other hierarchy.I decided not to support a case where one of the hierarchies is "in the middle" of the other hierarchy. The supported overlap cases are hierarchy ABC with AB, BC or CD, but not just B.
I also decided to do some small cleanups:
can_stack_to_top
->can_rhs_stack_on_lhs
because the previous one was confusing about the orderget_first_level_type
->get_first/last_level
, becauseget_first_level_type::level_type
seems weird.