Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsys-jax: roll back to 2024.4.1 and handle single-gpu profiles of single module executions better #988

Merged
merged 5 commits into from
Aug 9, 2024
Merged

nsys-jax: roll back to 2024.4.1 and handle single-gpu profiles of single module executions better #988

merged 5 commits into from
Aug 9, 2024

Conversation

olupton
Copy link
Collaborator

@olupton olupton commented Aug 9, 2024 •
edited
Loading

  • Nsight Systems 2024.5.1 is not currently supported by nsys-jax, roll it back while fixes are being prepared.
  • Handle profiles that do not contain any communication (i.e. single GPU runs) bettter.
  • Handle profiles that do not satisfy the warmup-removal heuristics more elegantly.

Closes #986.

@olupton olupton requested a review from gspschmid August 9, 2024 10:30
@olupton olupton force-pushed the olupton/nsys-jax-single-gpu branch from d45131d to ba11b6b Compare August 9, 2024 10:31
gspschmid
gspschmid approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@gspschmid gspschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olupton olupton merged commit 15e65e9 into main Aug 9, 2024
120 of 121 checks passed
@olupton olupton deleted the olupton/nsys-jax-single-gpu branch August 9, 2024 12:31
@olupton olupton mentioned this pull request Aug 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspschmid gspschmid gspschmid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyError: 'CollectiveSize' when running Analysis Jupyter script
2 participants
@olupton @gspschmid