Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove grok #975

Merged
merged 8 commits into from
Aug 14, 2024
Merged

Remove grok #975

merged 8 commits into from
Aug 14, 2024

Conversation

DwarKapex
Copy link
Contributor

No description provided.

@DwarKapex DwarKapex changed the title Vkozlov/remove grok Remove grok Aug 2, 2024
@DwarKapex DwarKapex requested review from yhtang, olupton, ko3n1g, terrykong and nouiz and removed request for yhtang and olupton August 5, 2024 20:22
terrykong
terrykong requested changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@terrykong terrykong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this PR also removed pax patch files and their reference in the manifest for some reason. Could you confirm if that was intentional?

@DwarKapex
Copy link
Contributor Author

DwarKapex commented Aug 12, 2024 •
edited
Loading

It looks like this PR also removed pax patch files and their reference in the manifest for some reason. Could you confirm if that was intentional?

I tried to remove everything, that has any connection to Grok. For instance, paxml/PR-93.patch updates the Grok classes. I'm under impression, that this is to support Grok.
Also praxis/PR-74.patch does some patches for Grok, but I'm not entirely sure I need to remove the whole patch or to do it partially.
WDYT @terrykong ?

terrykong
terrykong previously requested changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@terrykong terrykong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can revert/leave the pax stuff. The patches are orthogonal to the grok container since that's a different codebase entirely.

.github/container/manifest.yaml Outdated Show resolved Hide resolved
.github/container/manifest.yaml Outdated Show resolved Hide resolved
.github/container/patches/paxml/PR-93.patch Outdated Show resolved Hide resolved
.github/container/patches/praxis/PR-74.patch Outdated Show resolved Hide resolved
@olupton olupton dismissed terrykong’s stale review August 14, 2024 10:32

PAX changes were reverted

@olupton olupton merged commit d7bad4b into main Aug 14, 2024
159 of 166 checks passed
@olupton olupton deleted the vkozlov/remove-grok branch August 14, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olupton olupton olupton approved these changes

@yhtang yhtang Awaiting requested review from yhtang

@ko3n1g ko3n1g Awaiting requested review from ko3n1g

@nouiz nouiz Awaiting requested review from nouiz

@terrykong terrykong Awaiting requested review from terrykong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DwarKapex @olupton @terrykong