Install google.protobuf and protoc in containers #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widely varying versions of google.protobuf are installed in the containers depending on which other packages are installed. The approach here is to let pip-finalize.sh install whatever google.protobuf version it wants, and then try to install a compatible protoc.
olupton
force-pushed
the
olupton/install-protobuf
branch
from
38a0acc
to
9ed2874
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Widely varying versions of
google.protobuf(the Python runtime) are installed in the containers depending on which other packages are installed. The approach here is to letpip-finalize.shinstall whatevergoogle.protobufversion it wants, and then try to install a compatibleprotoc(the compiler /.proto->.pytranslator).This should allow some
virtualenvhackery to be removed, and also avoid hitting GitHub API rate limits.