Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model XLA Flags #1052

Merged
merged 7 commits into from
Sep 26, 2024
Merged

Model XLA Flags #1052

merged 7 commits into from
Sep 26, 2024

Conversation

terrykong
Copy link
Contributor

Moves XLA flags from model CI into their own files that can be sourced. Each file can be sourced and will print what it sets.

Some files source other files, which was intentional to avoid introducing sim-links into the repo, which can sometimes have platform issues (like on windows).

@terrykong
upstream XLA_FLAGS
eaac337 
Signed-off-by: Terry Kong <[email protected]>
@terrykong
Add t5 env
550d38d 
Signed-off-by: Terry Kong <[email protected]>
nouiz
nouiz reviewed Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@nouiz nouiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new files go in the right direction.
But they don't seem to be used in JAX-Toolbox. Should we make them used or document them in some way?

rosetta/rosetta/projects/pax/xla_flags/llama-7b.env Show resolved Hide resolved
rosetta/rosetta/projects/pax/xla_flags/grok-proxy.env Show resolved Hide resolved
@terrykong
remove $ in unset
067c484 
Signed-off-by: Terry Kong <[email protected]>
@terrykong
introduce threshold bytes
b05591a 
Signed-off-by: Terry Kong <[email protected]>
@terrykong
more variables
a4c6092 
Signed-off-by: Terry Kong <[email protected]>
@terrykong
add common.env
abc3554 
Signed-off-by: Terry Kong <[email protected]>
@terrykong terrykong merged commit 1a3febb into main Sep 26, 2024
69 of 71 checks passed
@terrykong terrykong deleted the terryk/model-xla-flags branch September 26, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DwarKapex DwarKapex DwarKapex left review comments

@nouiz nouiz nouiz left review comments

@ashors1 ashors1 ashors1 approved these changes

@yhtang yhtang Awaiting requested review from yhtang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@terrykong @nouiz @DwarKapex @ashors1