Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust test epsilons #5642

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adjust test epsilons #5642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dali/kernels/test/resampling_test/separable_3D_test.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2019, 2022, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// Copyright (c) 2019, 2022, 2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -446,8 +446,8 @@ class Resample3DTest<ResamplingTestParams<Out, In, interp>>
} else {
// Epsilons are quite big because, processing order in the reference is forced to be XYZ
// or YXZ, whereas the tested implementation can use any order.
double eps = std::is_integral<Out>::value ? 1 : 1e-3;
Check(out_cpu, ref_cpu, EqualEpsRel(eps, 1e-4));
double eps = std::is_integral<Out>::value ? 1 : 2e-3;
Check(out_cpu, ref_cpu, EqualEpsRel(eps, 1e-3));
}
}
}
Expand Down Expand Up @@ -501,7 +501,7 @@ class Resample3DTest<ResamplingTestParams<Out, In, interp>>
Check(out_cpu[i], ref_cpu[i]);
} else {
// Epsilons are quite big because:
// - GPU uses fma
// - GPU uses fma (the reference is GPU!)
// - GPU uses different rounding
// - processing order in the reference is forced to be XYZ or YXZ, whereas
// the tested implementation can use any order.
Expand Down
Loading