Coverity fixes 09-2024 #5633
Closed
Coverity fixes 09-2024 #5633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michał Szołucha <[email protected]>
|
!build |
|
CI MESSAGE: [18329280]: BUILD STARTED |
|
CI MESSAGE: [18329280]: BUILD FAILED |
mzient
reviewed
Sep 16, 2024
mzient
reviewed
Sep 16, 2024
Signed-off-by: Michał Szołucha <[email protected]>
|
!build |
|
CI MESSAGE: [18430989]: BUILD STARTED |
|
CI MESSAGE: [18430989]: BUILD FAILED |
mzient
reviewed
Sep 16, 2024
| @@ -54,7 +54,7 @@ void adjustMatrices(nvcv::Tensor &matrices, cudaStream_t stream) { | |||
|
|
|||
| int num_blocks = div_ceil(bs, 256); | |||
| int threads_per_block = std::min(bs, 256); | |||
| adjustMatricesKernel2<<<num_blocks, threads_per_block, 0, stream>>>(wrap, bs); | |||
| CUDA_CALL(adjustMatricesKernel2<<<num_blocks, threads_per_block, 0, stream>>>(wrap, bs)); | |||
There was a problem hiding this comment.
I don't think this would compile. A CUDA kernel invocation doesn't return a value.
Use CUDA_CALL(cudaGetLastError()); after the kernel invocation.
mzient
reviewed
Sep 16, 2024
| scratch.ToGPU(ws.stream(), pointers), | ||
| ws.NumInput() + 1, | ||
| N); | ||
| CUDA_CALL(Sum<<<div_ceil(N, 256), 256, 0, ws.stream()>>> |
stiepan
approved these changes
Sep 16, 2024
|
Fixes not posted. The changes are included in the replacement PR #5652 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
Coverity fixes for 09-2024
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A