Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport std::source_location with compiler builtins and make DALI_ENFORCE a function #5389

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

klecki
Copy link
Contributor

@klecki klecki commented Mar 21, 2024

Category: New feature

Description:

Remove the macros, embrace compiler extensions

Additional information:

Affected modules and functionalities:

Error checking etc.

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@klecki klecki marked this pull request as draft March 21, 2024 19:49
Copy link
Contributor

@mzient mzient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message in DALI_ENFORCE is meant to be lazily evaluated for performance and correctness reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants