EUSS HP-RTU measure updates #233
Open
+391,938
−2,854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubocop was already included in the gemspec. This adds a rake task to run rubocop on all ComStock ruby files.
- split measure tests into reporting, workflow, and upgrade - enforce rubocop standards on Gemfile and Rake file - update README.md
Add rubocop rake task
[WIP] Check the metadata in the postprocess when the pl.data in the memory
29 tasks
JanghyunJK
added
upgrade measure
… CCHPC to align with advanced perf.
| @@ -2746,9 +2746,9 @@ def run(runner, user_arguments) | |||
| coil_heating = airloopunisys.heatingCoil.get | |||
| # get appropriate cycling ratio timeseries depending on coil type | |||
| ts_cycling_ratio = nil | |||
| if coil_cooling.to_CoilCoolingDXTwoSpeed.is_initialized | |||
| if coil_heating.to_CoilCoolingDXTwoSpeed.is_initialized | |||
There was a problem hiding this comment.
@JanghyunJK to_CoilCoolingDXTwoSpeed -> should these be to_Coil**Heating**DXTwoSpeed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
@ChristopherCaradonna @carlobianchi89 this is the latest HPRTU measure PR!
This became a very complicated change including multiple sub-PRs and multiple updates on the same thing. But below are the summary of changes:
upgrade_hvac_add_heat_pump_rtumeasure (and corresponding unit tests) refactored and updatedcomstock_sensitivity_reportsmeasure updated to include cycling impactsthese sub-PRs include some major context of the changes
.evaluate2 #167.evaluate1 #166this PR also includes some other stuffs:
create_measure update to 3.8, os stds update to 0.6.1, and maybe more...updated some shared/test models to 3.8
Pull Request Author
This pull request makes changes to (select all the apply):
Author pull request checklist:
comstock_column_definitions.csvoptions_lookup.tsvfiles updated.ymlfilesREADME.mdfilestest/measure_tests.txtor/andtest/resource_measure_tests.txtReview Checklist
This will not be exhaustively relevant to every PR.