Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydrotools nwis-client requires python 3.7 #19

Open
hellkite500 opened this issue Jun 17, 2021 · 3 comments
Open

Hydrotools nwis-client requires python 3.7 #19

hellkite500 opened this issue Jun 17, 2021 · 3 comments

Comments

@hellkite500
Copy link
Member

The hydrotools nwis-client requires a minimum python version of 3.7. This means hypy needs to document a similar minimum version.

Current behavior

With latest version of hydrotools, hypy nwislocation doesn't work with python 3.6.

Steps to replicate behavior (include URLs)

Try running unit tests with python 3.6

@aaraney
Copy link
Member

aaraney commented Jun 17, 2021

This is because of the usage of aiohttp-client-cache. See here specifically for the downstream issue. At the surface level, it seems that the issue is just with aiohttp-client-cache's use of type hint features added in py37. It may be worth exploring this to see about a potential way around this and opening a PR there to lower the version requirement.

@aaraney
Copy link
Member

aaraney commented Jun 30, 2021

It's probably in our best interest to move to python 3.7 or greater as an organization. Python 3.6 will reach EOL this December.

@JWCook
Copy link

JWCook commented Aug 30, 2021

@aaraney Python 3.7 contains a large number of asyncio-specific improvements: https://docs.python.org/3/whatsnew/3.7.html#whatsnew37-asyncio

So it's highly recommended to use 3.7+ for async applications. It might be possible to make aiohttp-client-cache compatible with 3.6, but like you mentioned it will be EOL soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants