Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement corresponding service-side functionality to support TransportClientMultiplexer #449

Open
robertbartel opened this issue Oct 10, 2023 · 1 comment
Labels
Blocks Another issue is blocked until this is resolved bug Something isn't working maas MaaS Workstream

Comments

@robertbartel
Copy link
Contributor

Several new types - e.g., TransportClientMultiplexer - have been developed in #417 to address problems with sharing a single connection and message ordering. However, at this time, those changes only fully address these problems on the "client" side of connections.

Corresponding behavior needs to be implemented on the service side, through service manager classes directly and/or via AbstractRequestHandler and its subclasses.

This issue blocks the completion of #417.

@robertbartel robertbartel added bug Something isn't working maas MaaS Workstream labels Oct 10, 2023
@robertbartel robertbartel self-assigned this Oct 10, 2023
@robertbartel robertbartel added the Blocks Another issue is blocked until this is resolved label Oct 10, 2023
@robertbartel robertbartel removed their assignment Oct 10, 2023
@christophertubbs
Copy link
Contributor

Don't know if this helps at all, but I addressed a similar issue with the evaluation service connections by attaching optional request_ids to websocket requests and responses. 50k messages might be flying back and forth, but the client would know to update element x instead of element y because it was able to acknowledge the correct accompanying id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocks Another issue is blocked until this is resolved bug Something isn't working maas MaaS Workstream
Projects
None yet
Development

No branches or pull requests

2 participants