Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Consolidate data and app services #241

Closed
esheehan-gsl opened this issue Mar 17, 2023 · 0 comments · Fixed by #326
Closed

Consolidate data and app services #241

esheehan-gsl opened this issue Mar 17, 2023 · 0 comments · Fixed by #326
Assignees
Labels
shaping Status for project issues that are still being discussed

Comments

@esheehan-gsl
Copy link
Contributor

Problem

The data service is not entirely separate from the app (API) service. They need to share a data model. This results in some duplicated code—particularly for test fixtures—across both services. It also results in some odd package names: for the API, we have unified_graphics and for the data service we have ugdata.

Solution

Consolidate all of the services into one package.

It should be possible to fold the contents of the ugdata package into unified_graphics. We could approach the Lambda function in one of two ways:

  1. Include the aws.py module along with everything else, and just package it up in a separate Docker image for Lambda
  2. Move the actual ETL code from ugdata into unified_graphics but maintain a small service separately that includes the wrapper for Lambda from aws.py and has unified_graphics as a dependency

No Gos

Describe any features or behaviors that have been considered and rejected as out of scope for this project.

Rabbit Holes

Describe any solutions to problems that pose a risk to completing this project on time.

@esheehan-gsl esheehan-gsl added project shaping Status for project issues that are still being discussed labels Mar 17, 2023
@esheehan-gsl esheehan-gsl self-assigned this May 5, 2023
@esheehan-gsl esheehan-gsl linked a pull request May 5, 2023 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
shaping Status for project issues that are still being discussed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant