Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary makefiles from bufrsnd and lightning #60

Open
christopherwharrop-noaa opened this issue Dec 21, 2023 · 4 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@christopherwharrop-noaa
Copy link
Collaborator

Description

A few source directories contain makefiles and other related debugging or unused files. This repository uses a CMake build system and traditional makefiles serve no purpose. Also, debugging files and swap files should not be stored in the repository. The extraneous files cause confusion and clutter and should be cleaned up.

Solution

Remove the following makefiles from the repository:

lightning.fd/makefile
bufrsnd.fd/rrfs_bufr.fd/makefile
bufrsnd.fd/rrfs_bufr.fd/makefile
bufrsnd.fd/rrfs_stnmlist.fd/makefile
bufrsnd.fd/rrfs_stnmlist.fd/makefile.orig
bufrsnd.fd/rrfs_bufr.fd/makefile_debug_try_fails
rtma_minmaxtrh.fd/maxrh.fd/makefile
rtma_minmaxtrh.fd/minrh.fd/makefile
rtma_minmaxtrh.fd/maxtbg.fd/makefile
rtma_minmaxtrh.fd/mintbg.fd/makefile
lakesurgery.fd/.makefile.swp
cloudanalysis.fd/NonVarCldLib/make.filelist
@christopherwharrop-noaa
Copy link
Collaborator Author

christopherwharrop-noaa commented Dec 21, 2023

@chan-hoo - Some of these may be yours, but I was not able to add your username to the assignee list for some reason. Please take a look.

@chan-hoo
Copy link
Contributor

@christopherwharrop-noaa, I updated the cmake file to add the switch for each executable a couple of weeks ago, but I didn't develop any files in rrfs_utl.

@christopherwharrop-noaa
Copy link
Collaborator Author

@chan-hoo - Ok. Your name was attached to some of the commits, so I thought you might be involved with those. Maybe it was because you changed the name of all the directories recently. Thanks!

@christopherwharrop-noaa
Copy link
Collaborator Author

Perhaps @guoqing-noaa knows the developer responsible for each of the individual apps and can ask them to clean them up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants