Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces mpp_recv and mpp_send and uses mpi_gather and mpi_scatterv within mpp_scatter_pelist #1240

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

ganganoaa
Copy link
Contributor

Description
The original mpp_scatter used point-to-point communications: _mpp_recv and mpp_send to gather at and scatter from the root pe. This update replaces the point-to-point communications and uses standard collective communications: mpi_gather and mpi_scatterv to achieve the data transfer.

Fixes # (issue)

How Has This Been Tested?
Tested locally with Intel oneAPI (v2023.1.0); intel ifort (v2021.9.0).

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@bensonr
Copy link
Contributor

bensonr commented Jun 1, 2023

@ganganoaa - can you include this new version in parallel with the existing version? This will allow us evaluate performance in many different scenarios via different test cases.

@ganganoaa
Copy link
Contributor Author

It has issues with non-MPI compilation. So, I am updating it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants