Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the marine_da_utils run method more flexible #2950

Closed
DavidHuber-NOAA opened this issue Sep 23, 2024 · 2 comments
Closed

Make the marine_da_utils run method more flexible #2950

DavidHuber-NOAA opened this issue Sep 23, 2024 · 2 comments
Labels
feature New feature or request triage Issues that are triage

Comments

@DavidHuber-NOAA
Copy link
Contributor

What new functionality do you need?

The run method should be able to take in both the Executable and the command line arguments as a list, following e.g. wxflow's Htar class.

What are the requirements for the new functionality?

Marine DA Executable instances should not specify default_args except when those executables are reused.

Acceptance Criteria

DA job outputs are unchanged.

Suggest a solution (optional)

Something like

to something like

    def run(self, arg_list: list, silent: bool = False) -> str:

        # Remove any empty arguments which can cause issues for running an Executable
        arg_list = [arg for arg in arg_list if arg != ""]

        if silent:
            output = self.exe(*arg_list, output=str, error=str)
        else:
            output = self.exe(*arg_list, output=str.split, error=str.split)

        return output
@DavidHuber-NOAA DavidHuber-NOAA added feature New feature or request triage Issues that are triage labels Sep 23, 2024
@DavidHuber-NOAA DavidHuber-NOAA changed the title Make the marein_da_utils run method more flexible Make the marine_da_utils run method more flexible Sep 23, 2024
@DavidNew-NOAA
Copy link
Contributor

When I incorporate the Jedi class into the marine jobs (see #2931), it will be using the execute from that class for running JEDI-based applications. (see

def execute(self, task_config: AttrDict, aprun_cmd: str, jedi_args: Optional[List] = None) -> None:
)

@DavidHuber-NOAA
Copy link
Contributor Author

Good to know, thanks! I will close this as not planned in favor of #2931 then.

@DavidHuber-NOAA DavidHuber-NOAA closed this as not planned Won't fix, can't repro, duplicate, stale Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request triage Issues that are triage
Projects
None yet
Development

No branches or pull requests

2 participants