Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GDASApp to spack-stack/1.5.0 #656

Merged

Conversation

RussTreadon-NOAA
Copy link
Contributor

This PR updates hera.lua and orion.lua in modulefiles/GDAS to spack-stack/1.5.0. This is the version of spack-stack used by the SkyLab v6 release. As explained in issue #654, we need to build GDASApp with spack-stack/1.5.0 to pull in bufr/12.0.0.

Fixes #654

The spack-stack/1.5.0 GDASApp has been built in both stand-alone mode and inside g-w with ctests run in both configurations. All test_gdasapp ctests pass on both Hera and Orion.

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Oct 4, 2023
@RussTreadon-NOAA RussTreadon-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Oct 4, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Oct 4, 2023
@emcbot
Copy link

emcbot commented Oct 4, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Oct  4 02:35:52 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Oct  4 03:39:58 UTC 2023
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Wed Oct  4 04:20:47 UTC 2023
Tests: 100% tests passed, 0 tests failed out of 54

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Oct 4, 2023
@emcbot
Copy link

emcbot commented Oct 4, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Tue Oct  3 21:32:29 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Oct  3 22:51:49 CDT 2023
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Tue Oct  3 23:24:05 CDT 2023
Tests: 100% tests passed, 0 tests failed out of 54

@emcbot emcbot added orion-GW-RT-Passed Automated testing with global-workflow successful on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Oct 4, 2023
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @RussTreadon-NOAA

Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RussTreadon-NOAA
Copy link
Contributor Author

Thank you, @guillaumevernieres and @AndrewEichmann-NOAA , for your quick reviews and approvals.

@RussTreadon-NOAA RussTreadon-NOAA merged commit ff8a0ec into NOAA-EMC:develop Oct 4, 2023
14 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/spack-stack branch October 4, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera orion-GW-RT-Passed Automated testing with global-workflow successful on Orion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Hera and Orion builds to spack-stack/1.5.0
4 participants