Using already created communicator ... and more #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumevernieres
requested review from
AndrewEichmann-NOAA,
apchoiCMD,
ShastriPaturi and
rmclaren
apchoiCMD
previously approved these changes
Oct 3, 2023
|
@guillaumevernieres So this means we should be able to test with multiple input files? |
@AndrewEichmann-NOAA , yes, but my tests started hanging in the gather again last night ... Same code. I added a few barriers and it started going through again, but that doesn't make any sense. I thought I found the bug, but looks like not! |
apchoiCMD
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few bux fixes:
oops::mpi::world()was an issues. The comm is now using the one defined inApplicationand was added as a data member ofNetCDFToIodaConverter.This worked with the 5 RADS files that I have, which is a change from "not working", but the obs count is quite low at ~200,000. We'll declare victory when we successfully test with the other observations.