Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concatenation of adt's into 1 ObsSpace, cp0.b QC for adt and sst #598

Merged
merged 3 commits into from
Sep 2, 2023
Merged

Concatenation of adt's into 1 ObsSpace, cp0.b QC for adt and sst #598

merged 3 commits into from
Sep 2, 2023

Conversation

guillaumevernieres
Copy link
Contributor

New QC parameters

  • Update of the SST QC following what was done for cp0.b.

  • Altimeters from the RADS can be safely concatenated into 1 obs space, that should have been done ages ago!

  • fixes Update QC and obs ingest #597

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Sep 1, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Sep 1, 2023
@emcbot
Copy link

emcbot commented Sep 1, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Fri Sep  1 13:49:06 UTC 2023 on hfe07
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Fri Sep  1 14:11:45 UTC 2023
Build: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/598/global-workflow/sorc/log.build

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Sep 1, 2023
@emcbot
Copy link

emcbot commented Sep 1, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Fri Sep  1 08:47:45 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Fri Sep  1 09:17:12 CDT 2023
Build: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/598/global-workflow/sorc/log.build

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Sep 1, 2023
@guillaumevernieres
Copy link
Contributor Author

An unfortunate ioda PR:
https://github.com/JCSDA-internal/ioda/pull/1077/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR58

@hyunchul386
Copy link
Collaborator

For me, the changes in SST filters and background errors looks fine.

hyunchul386
hyunchul386 previously approved these changes Sep 1, 2023
View reviewed changes
ShastriPaturi
ShastriPaturi approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@ShastriPaturi ShastriPaturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

parm/soca/obs/config/sst_metopa_l3u_so025.yaml Show resolved Hide resolved
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion labels Sep 1, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Sep 1, 2023
@emcbot
Copy link

emcbot commented Sep 1, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Fri Sep  1 16:32:33 UTC 2023 on hfe07
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Fri Sep  1 16:57:12 UTC 2023
Build: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/598/global-workflow/sorc/log.build

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Sep 1, 2023
@emcbot
Copy link

emcbot commented Sep 1, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Fri Sep  1 11:31:08 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Fri Sep  1 12:03:12 CDT 2023
Build: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/598/global-workflow/sorc/log.build

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Sep 1, 2023
@CoryMartin-NOAA CoryMartin-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion labels Sep 1, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Sep 1, 2023
@emcbot
Copy link

emcbot commented Sep 1, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Fri Sep  1 17:49:50 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Sep  1 19:00:05 UTC 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Fri Sep  1 20:02:18 UTC 2023
Tests: 98% tests passed, 1 tests failed out of 49
	1612 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/598/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Sep 1, 2023
@emcbot
Copy link

emcbot commented Sep 1, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Fri Sep  1 12:47:38 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Sep  1 14:33:50 CDT 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Fri Sep  1 15:08:59 CDT 2023
Tests: 98% tests passed, 1 tests failed out of 49
	1612 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/598/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Sep 1, 2023
@guillaumevernieres guillaumevernieres merged commit a4c5d96 into develop Sep 2, 2023
13 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/update-obsqc branch September 11, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShastriPaturi ShastriPaturi ShastriPaturi approved these changes

@hyunchul386 hyunchul386 hyunchul386 left review comments

Assignees
No one assigned
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update QC and obs ingest
5 participants
@guillaumevernieres @emcbot @hyunchul386 @ShastriPaturi @CoryMartin-NOAA