Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snow DA cycling for the fractional grid setting. #504

Merged
merged 14 commits into from
Jul 7, 2023
Merged

Update snow DA cycling for the fractional grid setting. #504

merged 14 commits into from
Jul 7, 2023

Conversation

jiaruidong2017
Copy link
Collaborator

@jiaruidong2017 jiaruidong2017 commented Jun 11, 2023 •
edited
Loading

Changes need for Land DA PR in global-workflow (NOAA-EMC/global-workflow#1687)

Modify the state variable for handling with or without the fractional grid cells settings (snodl vs snwdph) in GFSv17.

This PR allows users to assign the constant obs errors in the yaml files.

@jiaruidong2017 jiaruidong2017 mentioned this pull request Jun 11, 2023
Merged
9 tasks
aerorahul
aerorahul requested changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am reviewing this in the context of the global-workflow PR NOAA-EMC/global-workflow#1687

ush/land/gfs-land_gfsv17.yaml Outdated Show resolved Hide resolved
parm/land/letkfoi/letkfoi.yaml Outdated Show resolved Hide resolved
parm/land/letkfoi/letkfoi.yaml Outdated Show resolved Hide resolved
test/land/letkfoi_snowda.sh Outdated Show resolved Hide resolved
@jiaruidong2017 jiaruidong2017 marked this pull request as draft June 14, 2023 00:55
@jiaruidong2017 jiaruidong2017 added the hera-RT Queue for automated testing on Hera label Jun 24, 2023
@emcbot emcbot added hera-RT-Running Automated testing running on Hera and removed hera-RT Queue for automated testing on Hera labels Jun 24, 2023
@emcbot
Copy link

emcbot commented Jun 24, 2023

Automated GDASApp Testing Results:
Machine: hera

Start: Sat Jun 24 16:30:24 UTC 2023 on hfe10
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Sat Jun 24 17:11:03 UTC 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Sat Jun 24 17:12:10 UTC 2023
Tests: 96% tests passed, 1 tests failed out of 28
	1479 - test_gdasapp_land_letkfoi_snowda (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/PR/504/GDASApp/build/log.ctest

@emcbot emcbot added hera-RT-Failed Automated testing failed on Hera and removed hera-RT-Running Automated testing running on Hera labels Jun 24, 2023
@jiaruidong2017
Copy link
Collaborator Author

This PR depends on https://github.com/JCSDA-internal/fv3-jedi/pull/927

@CoryMartin-NOAA CoryMartin-NOAA removed the hera-RT-Failed Automated testing failed on Hera label Jul 6, 2023
@CoryMartin-NOAA CoryMartin-NOAA marked this pull request as ready for review July 7, 2023 19:40
aerorahul
aerorahul approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@CoryMartin-NOAA CoryMartin-NOAA merged commit e963914 into develop Jul 7, 2023
5 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/land_snodl branch July 7, 2023 19:46
@jiaruidong2017
Copy link
Collaborator Author

Thanks @CoryMartin-NOAA @aerorahul

Would you please merge branch 'develop' into feature/stable-nightly for my global-workflow tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

@aerorahul aerorahul aerorahul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiaruidong2017 @emcbot @CoryMartin-NOAA @aerorahul