Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup audit github actions, which will scan for npm packages vulnerabilities #224

Open
Tracked by #11
tomaspalma opened this issue Jul 17, 2024 · 2 comments
Open
Tracked by #11

Comments

@tomaspalma
Copy link
Member

tomaspalma commented Jul 17, 2024

Before merging a pull request, we should have an action that checks if vulnerabilities were found in any of the packages

@tomaspalma tomaspalma mentioned this issue Jul 17, 2024
4 tasks
@tomaspalma tomaspalma changed the title audit, which will scan for npm packages vulnerabilities Setup audit github actions, which will scan for npm packages vulnerabilities Jul 17, 2024
@thePeras
Copy link
Member

thePeras commented Aug 7, 2024

I have just enabled the first, which already done that with dependabot.
Should we enable the second one to open a PR?

Feel free to config these settings in your self

Screenshot 2024-08-07 at 11 20 31

@tomaspalma
Copy link
Member Author

tomaspalma commented Aug 7, 2024

Thank you!

I think that the dependabot part might be more suitable for the #225 issue.

This one was more to have the npm run audit command ran when a PR tried to merge into the develop. Although the dependabot will alert for vulnerabilities for dependencies already in our project, it won't alert for new dependencies that will be merged by a PR.

Should we enable the second one to open a PR?

I believe it is a good idea even though it may add noise to the PR tab, security is important

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants