Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player's progress bar in webreport videos obscures patient's feet #12

Open
andreyzhd opened this issue Jan 19, 2023 · 2 comments
Open

Comments

@andreyzhd
Copy link
Collaborator

Even if the progress bar itself does not obscure the feet, the player window adds a semiopaque area around the progress bar that degrades the video quality in the feet area. The problem doesn't happen for the overlay videos as they have a black frame around the actual video.
One straightforward solution is just to add a black stripe below each non-overlay video.

@jjnurminen
Copy link
Collaborator

A longstanding issue. The ideal solution might be to ditch the Chrome video player and create/obtain a Dash video player component that would handle also other useful things, like synchronization with gait curves. (I believe that Dash components are just lightly wrapped React components, but never looked deeply into this).

@jjnurminen
Copy link
Collaborator

jjnurminen commented Jan 20, 2023

Here's a Dash video player component that wraps ReactPlayer: https://github.com/plotly/dash-player
It might be an improvement on the Chrome player even out of the box, or at least a starting point. It seems to support e.g. seeking by API calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants