Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining NEON edits / changes #73

Open
9 of 10 tasks
aebudden opened this issue Jan 6, 2021 · 5 comments
Open
9 of 10 tasks

Remaining NEON edits / changes #73

aebudden opened this issue Jan 6, 2021 · 5 comments
Assignees

Comments

@aebudden
Copy link
Contributor

aebudden commented Jan 6, 2021

  • General: All external links to open in a new window
  • Section 1.1: Video frames not rendering in online. Fine in local copy. Video in Section 4.4 is fine both online and in local build
  • Section 3.1.3.2: Have paragraphs start under the bold headers
  • Section 3.1.4: Create visual separation between the two exercises
  • Section 3.1.4: Horizontal division bar is sitting within the exercise box
  • Section 3.3.2.7: Add some buffer between the RHS of the image and the text
  • Section 3.3.2.9: Missing image / code error
  • Section 3.3.2.9: Image credit separated from image location
  • Section 3.4.1: Capitalize first title word
  • Section 3.4.3: Typo 'resources' under DLC image
@ggwillard
Copy link

ggwillard commented Jan 7, 2021

  • Section 3.1.4.2 (bottom of the green "exercise" box): typo, should say "Thinking" not Tinking

@brunj7
Copy link
Contributor

brunj7 commented Jan 8, 2021

  • Section about this resource: R version is outdated, bump it to the latest 4.0.3
  • Section 1.1: the videos are not showing up (it does on the local version, might be a github pages thing)
  • Section 2.1.2: ...activity Inclusion <- fix case
  • Section 2.1.2, under Explore alignment: I think there is a word missing in this sentence: There are many online resources available to help, however you may also with to talk to individuals within those positions.
  • Section 3.1.2: add reference to section 3.4 at the end

@aebudden
Copy link
Contributor Author

aebudden commented Jan 8, 2021

@brunj7 Are you able to problem solve 1.1?

@brunj7
Copy link
Contributor

brunj7 commented Jan 8, 2021

@aebudden yes! 1.1 and I can go through the edits in 1-hour (have some calls ahead). Please keep the checkboxes updated if you have time to tackle some before

brunj7 added a commit to brunj7/nceas-training that referenced this issue Jan 8, 2021
@brunj7 brunj7 mentioned this issue Jan 9, 2021
@brunj7
Copy link
Contributor

brunj7 commented Jan 10, 2021

most of those edits have been implemented by #78

Note that I am not aware of a way to make all the links open into a new window/tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants