Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure postgres connections are closed properly and other minor changes #421

Merged
merged 21 commits into from
May 3, 2024

Conversation

jeanetteclark
Copy link
Collaborator

Copy link
Contributor

@artntek artntek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a big fan of reformatting files to comply with the codestyle settings. There are a couple of gotchas to watch out for, though:

  1. If I reformat an entire file, I can't trust the IDE completely. I always find I need to look through the resulting code and make manual tweaks to the formatting/flow, because it doesn't wrap javadoc comments well, for example, or breaks concatenated strings over multiple lines needlessly etc. I flagged a few of these in your code below, but there were many more I didn't flag.
  2. When you reformat an entire file, it's almost impossible for a reviewer to find the actual code changes you have made, so they may miss an important detail. The best approach is to split the reformatting and the code changes across 2 separate PRs, but since that's not always possible, a good alternative is to at least push separate commits for the reformat and the code changes. Failing both of those, a final option is to addd some comments to the PR to show where the actual code changes are.

I searched for try (, so found your changes, but I hope I didn't miss anything else :-)

helm/metadig-scheduler/values.yaml Show resolved Hide resolved
helm/metadig-scorer/values.yaml Show resolved Hide resolved
helm/metadig-worker/templates/deployment.yaml Outdated Show resolved Hide resolved
helm/metadig-controller/values.yaml Show resolved Hide resolved
helm/metadig-worker/values.yaml Show resolved Hide resolved
@jeanetteclark jeanetteclark merged commit 2773529 into develop May 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants