Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Add some more tests for parsing comments #738

Merged
merged 1 commit into from
Oct 20, 2024
Merged

[TASK] Add some more tests for parsing comments #738

merged 1 commit into from
Oct 20, 2024

Conversation

oliverklee
Copy link
Contributor

@oliverklee oliverklee commented Oct 20, 2024 •
edited
Loading

Also add a skipped test for the broken behavior that currently
is blocking Emogrifier.

@oliverklee oliverklee self-assigned this Oct 20, 2024
@oliverklee oliverklee marked this pull request as draft October 20, 2024 15:27
@coveralls
Copy link

coveralls commented Oct 20, 2024 •
edited
Loading

Coverage Status

coverage: 38.652%. remained the same
when pulling 62c9815 on task/more-tests
into 9974bbf on main.

@oliverklee
[TASK] Add some more tests for parsing comments
62c9815 
Also add a skipped test for the broken behavior that currently
is blocking Emogrifier.
@oliverklee oliverklee marked this pull request as ready for review October 20, 2024 15:54
JakeQZ
JakeQZ approved these changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a case for using a 'cross' data provider to generate the combinations of CSS with/without strict parsing. But we plan to remove the strict parsing setting anyway, and aren't currently using the package that facilitates 'cross' providers.

@JakeQZ JakeQZ merged commit e2bb6b7 into main Oct 20, 2024
20 checks passed
@JakeQZ JakeQZ deleted the task/more-tests branch October 20, 2024 17:43
@JakeQZ
Copy link
Contributor

JakeQZ commented Oct 20, 2024

This might be a case for using a 'cross' data provider to generate the combinations of CSS with/without strict parsing.

Oh, I've just spotted that the strict mode test is skipped.

oliverklee added a commit that referenced this pull request Oct 23, 2024
@oliverklee
[TASK] Add some more tests for parsing comments
a9c061d 
Also add a skipped test for the broken behavior that currently
is blocking Emogrifier.

This is the 8.x backport of #738.
@oliverklee oliverklee mentioned this pull request Oct 23, 2024
Merged
oliverklee added a commit that referenced this pull request Oct 23, 2024
@oliverklee
[TASK] Add some more tests for parsing comments
3ce5e9a 
Also add a skipped test for the broken behavior that currently
is blocking Emogrifier.

This is the 8.x backport of #738.
oliverklee added a commit that referenced this pull request Oct 23, 2024
@oliverklee
[TASK] Add some more tests for parsing comments
611f521 
Also add a skipped test for the broken behavior that currently
is blocking Emogrifier.

This is the 8.x backport of #738.
JakeQZ pushed a commit that referenced this pull request Oct 23, 2024
@oliverklee
[TASK] Add some more tests for parsing comments (#739)
404aff3 
Also add a skipped test for the broken behavior that currently
is blocking Emogrifier.

This is the 8.x backport of #738.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels
to-backport
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ