Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the behaviour of minimum memory allocation field #5460

Open
1 task done
Icoryx opened this issue Jul 6, 2024 · 0 comments
Open
1 task done

Change the behaviour of minimum memory allocation field #5460

Icoryx opened this issue Jul 6, 2024 · 0 comments
Labels
suggestion Feature suggestions that have not been accepted yet.

Comments

@Icoryx
Copy link

Icoryx commented Jul 6, 2024

Role

I play modded MC

Suggestion

It should only update the min mem alloc field when the max mem alloc field isn't active anymore or finish is clicked.

Benefit

Not having to enter the minimum alloc twice

This suggestion is unique

  • I have searched the issue tracker and did not find an issue describing my suggestion, especially not one that has been rejected.

You may use the editor below to elaborate further.

Issue:

When MultiMC asks you to choose a java version and enter how much ram it should use the minimum memory allocation field get's updated to a smaller value even when entering a higher value.

It happens like this:

  1. You enter a value in min mem alloc for example 4096
  2. You enter a higher value in max mem alloc for example 16384

As soon as you enter the 3 it updates min mem alloc to 163. For some reason it doesn't do it before that or after entering the 8 (1638<4096). This should only happen when the full value was entered and it's lower than min mem alloc.

Fix:

Change when the field gets updated. Instead of checking for a lower value after every character that is entered only check when the field loses focus or the finish button is clicked. Could also stop it from automatically updating, add a warning that the values don't work together and disable the button.

@phit phit added the suggestion Feature suggestions that have not been accepted yet. label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion Feature suggestions that have not been accepted yet.
Projects
None yet
Development

No branches or pull requests

2 participants