Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at extracting digis from tracks #1343

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edcallaghan
Copy link
Contributor

This PR implements a modules which deep-copies StrawDigis and StrawDigiWaveforms which are associated with a reconstructed track via KalSeed into new *Collections. This PR is marked as a draft for now; more detail will be added here before it's necessary to initiate review.

@FNALbuild
Copy link
Collaborator

Hi @edcallaghan,
You have proposed changes to files in these packages:

  • Blinding

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for c086bf4: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☀️ The build tests passed at c086bf4.

Test Result Details
test with Command did not list any other PRs to include
merge Merged c086bf4 at 38f72f8
build (prof) Log file. Build time: 08 min 48 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO TODO (0) FIXME (0) in 1 files
clang-tidy 🔶 0 errors 103 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at c086bf4 after being merged into the base branch at 38f72f8.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@edcallaghan edcallaghan marked this pull request as draft September 24, 2024 19:06
Copy link
Collaborator

@brownd1978 brownd1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it makes sense to combine this module with the time-shifting module, as I suspect both will end up needing to reference a track, and both otherwise produce and consume the same products. It seem more efficient to do this in one pass.

@FNALbuild
Copy link
Collaborator

📝 The HEAD of main has changed to 5694fbe. Tests are now out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants