Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at KalSeedCollection sculpting modules #1342

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edcallaghan
Copy link
Contributor

This PR implements a system of modules for filtering KalSeeds out of events using arbitrary 1-dimensional functional prescales across a few variables. This PR is marked as a draft for now; modification and much more details will be added here before it's necessary to initiate review.

…mentation for the univariate case, including momentum, azimuthal track coordinate, and quasi-impact parameter
@FNALbuild
Copy link
Collaborator

Hi @edcallaghan,
You have proposed changes to files in these packages:

  • Blinding

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for a2f17e0: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☔ The build is failing at a2f17e0.

scons: *** [build/al9-prof-e28-p061/Offline/tmp/Blinding/src/MomentumLookupKalSeedPrescaleTool_tool.os] Error 1
scons: *** [build/al9-prof-e28-p061/Offline/tmp/Blinding/src/TrackerExitAzimuthLookupKalSeedPrescaleTool_tool.os] Error 1
scons: *** [build/al9-prof-e28-p061/Offline/tmp/Blinding/src/QuasiImpactParameterLookupKalSeedPrescaleTool_tool.os] Error 1
Test Result Details
test with Command did not list any other PRs to include
merge Merged a2f17e0 at 38f72f8
build (prof) Log file.
ceSimReco 〰️ Log file.
g4test_03MT 〰️ Log file.
transportOnly 〰️ Log file.
POT 〰️ Log file.
g4study 〰️ Log file.
cosmicSimReco 〰️ Log file.
cosmicOffSpill 〰️ Log file.
ceSteps 〰️ Log file.
ceDigi 〰️ Log file.
muDauSteps 〰️ Log file.
ceMix 〰️ Log file.
rootOverlaps 〰️ Log file.
g4surfaceCheck 〰️ Log file.
FIXME, TODO 🔶 TODO (2) FIXME (0) in 11 files
clang-tidy 🔶 22 errors 637 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at a2f17e0 after being merged into the base branch at 38f72f8.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@edcallaghan edcallaghan marked this pull request as draft September 24, 2024 19:06
Copy link
Collaborator

@brownd1978 brownd1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to extend this module to use extrapolated positions at the stopping target instead of the tracker?

@FNALbuild
Copy link
Collaborator

📝 The HEAD of main has changed to 5694fbe. Tests are now out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants